Skip to content

Commit

Permalink
address review comment, added warning to host replace as well
Browse files Browse the repository at this point in the history
  • Loading branch information
ron-saito committed Oct 31, 2023
1 parent 1f696f0 commit 7449e18
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 11 deletions.
2 changes: 1 addition & 1 deletion v1/api/swagger/paths/hosts@{hostId}@reimage.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ post:
summary: Reimage Host by ID
description: >-
Re-deploys a host to the same machine.
Warning, all drives will be erased!
WARNING -- all drives will be erased!
Only the Host OS is reinstalled, IP addresses, volumes, etc are not changed.
The host must be powered off. The host must also be in the Ready state.
operationId: reimage
Expand Down
1 change: 1 addition & 0 deletions v1/api/swagger/paths/hosts@{hostId}@replace.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ post:
summary: Replace Host by ID
description: >-
Re-deploys a host with a new machine that satisfies the current host settings.
WARNING -- all drives will be erased!
Only the machine is replaced, IP addresses, volumes, etc are not changed.
The host must be powered off. The host must also be in the Ready state or in
the Failed state and in the Replace or Maintenace workflow.
Expand Down
9 changes: 5 additions & 4 deletions v1/pkg/client/api/openapi.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1177,7 +1177,7 @@ paths:
summary: Set a specific host to attempt HDD boot
/hosts/{hostId}/reimage:
post:
description: Re-deploys a host to the same machine. Warning, all drives will
description: Re-deploys a host to the same machine. WARNING -- all drives will
be erased! Only the Host OS is reinstalled, IP addresses, volumes, etc are
not changed. The host must be powered off. The host must also be in the Ready
state.
Expand Down Expand Up @@ -1227,9 +1227,10 @@ paths:
/hosts/{hostId}/replace:
post:
description: Re-deploys a host with a new machine that satisfies the current
host settings. Only the machine is replaced, IP addresses, volumes, etc are
not changed. The host must be powered off. The host must also be in the Ready
state or in the Failed state and in the Replace or Maintenace workflow.
host settings. WARNING -- all drives will be erased! Only the machine is replaced,
IP addresses, volumes, etc are not changed. The host must be powered off. The
host must also be in the Ready state or in the Failed state and in the Replace
or Maintenace workflow.
operationId: replace
parameters:
- description: ID of Host to replace
Expand Down
4 changes: 2 additions & 2 deletions v1/pkg/client/api_hosts.go
Original file line number Diff line number Diff line change
Expand Up @@ -1506,7 +1506,7 @@ func (a *HostsApiService) PowerReset(ctx _context.Context, hostId string) (Host,

/*
Reimage Reimage Host by ID
Re-deploys a host to the same machine. Warning, all drives will be erased! Only the Host OS is reinstalled, IP addresses, volumes, etc are not changed. The host must be powered off. The host must also be in the Ready state.
Re-deploys a host to the same machine. WARNING -- all drives will be erased! Only the Host OS is reinstalled, IP addresses, volumes, etc are not changed. The host must be powered off. The host must also be in the Ready state.
* @param ctx _context.Context - for authentication, logging, cancellation, deadlines, tracing, etc. Passed from http.Request or context.Background().
* @param hostId ID of Host to reimage
@return Host
Expand Down Expand Up @@ -1657,7 +1657,7 @@ func (a *HostsApiService) Reimage(ctx _context.Context, hostId string) (Host, *_

/*
Replace Replace Host by ID
Re-deploys a host with a new machine that satisfies the current host settings. Only the machine is replaced, IP addresses, volumes, etc are not changed. The host must be powered off. The host must also be in the Ready state or in the Failed state and in the Replace or Maintenace workflow.
Re-deploys a host with a new machine that satisfies the current host settings. WARNING -- all drives will be erased! Only the machine is replaced, IP addresses, volumes, etc are not changed. The host must be powered off. The host must also be in the Ready state or in the Failed state and in the Replace or Maintenace workflow.
* @param ctx _context.Context - for authentication, logging, cancellation, deadlines, tracing, etc. Passed from http.Request or context.Background().
* @param hostId ID of Host to replace
@return Host
Expand Down
4 changes: 2 additions & 2 deletions v1/pkg/client/docs/HostsApi.md
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ Name | Type | Description | Notes
Reimage Host by ID

Re-deploys a host to the same machine. Warning, all drives will be erased! Only the Host OS is reinstalled, IP addresses, volumes, etc are not changed. The host must be powered off. The host must also be in the Ready state.
Re-deploys a host to the same machine. WARNING -- all drives will be erased! Only the Host OS is reinstalled, IP addresses, volumes, etc are not changed. The host must be powered off. The host must also be in the Ready state.

### Required Parameters

Expand Down Expand Up @@ -409,7 +409,7 @@ Name | Type | Description | Notes
Replace Host by ID

Re-deploys a host with a new machine that satisfies the current host settings. Only the machine is replaced, IP addresses, volumes, etc are not changed. The host must be powered off. The host must also be in the Ready state or in the Failed state and in the Replace or Maintenace workflow.
Re-deploys a host with a new machine that satisfies the current host settings. WARNING -- all drives will be erased! Only the machine is replaced, IP addresses, volumes, etc are not changed. The host must be powered off. The host must also be in the Ready state or in the Failed state and in the Replace or Maintenace workflow.

### Required Parameters

Expand Down
4 changes: 2 additions & 2 deletions v1/pkg/client/interface_hosts.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 7449e18

Please sign in to comment.