Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test/stark #85

Merged
merged 25 commits into from
Jan 25, 2024
Merged

Test/stark #85

merged 25 commits into from
Jan 25, 2024

Conversation

Okm165
Copy link
Collaborator

@Okm165 Okm165 commented Jan 20, 2024

No description provided.

@Okm165 Okm165 self-assigned this Jan 20, 2024
@Okm165 Okm165 marked this pull request as draft January 20, 2024 09:45
This was linked to issues Jan 20, 2024
Develop stark-verify functionality #50
Closed
Develop stark-commit functionality #49
Closed
@Okm165 Okm165 removed a link to an issue Jan 20, 2024
Develop stark-commit functionality #49
Closed
@Okm165
Copy link
Collaborator Author

Okm165 commented Jan 20, 2024 •
edited
Loading

DO NOT MERGE TO MAIN scarb test takes 40G of ram due to stark_verify test
multiple evals of eval_oods_polynomial are main cause of big resources usage
ACTIONS fail due to big resources usage
I can run tests successfully on my machine

@Okm165
Copy link
Collaborator Author

Okm165 commented Jan 22, 2024

all tests are WORKING

@Okm165
Copy link
Collaborator Author

Okm165 commented Jan 23, 2024

major improvement in resources consumption thanks to 9b7a354

@Okm165 Okm165 marked this pull request as ready for review January 24, 2024 10:26
@neotheprogramist
Copy link
Contributor

This PR fixes #87

@neotheprogramist neotheprogramist mentioned this pull request Jan 24, 2024
Closed
neotheprogramist
neotheprogramist reviewed Jan 24, 2024
View reviewed changes
src/stark.cairo Outdated Show resolved Hide resolved
neotheprogramist
neotheprogramist reviewed Jan 24, 2024
View reviewed changes
src/stark.cairo Outdated Show resolved Hide resolved
neotheprogramist
neotheprogramist reviewed Jan 24, 2024
View reviewed changes
src/stark.cairo Outdated Show resolved Hide resolved
@neotheprogramist neotheprogramist self-requested a review January 24, 2024 10:36
neotheprogramist
neotheprogramist approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@neotheprogramist neotheprogramist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Okm165 Okm165 merged commit 2ab63d5 into main Jan 25, 2024
2 checks passed
@Okm165 Okm165 deleted the test/stark branch February 12, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neotheprogramist neotheprogramist neotheprogramist approved these changes

@tiagofneto tiagofneto Awaiting requested review from tiagofneto

@fmkra fmkra Awaiting requested review from fmkra

Assignees

@Okm165 Okm165

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Develop stark-verify functionality
2 participants
@Okm165 @neotheprogramist