Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/updates-and-enhancements #60

Merged
merged 7 commits into from
Jan 15, 2024
Merged

feat/updates-and-enhancements #60

merged 7 commits into from
Jan 15, 2024

Conversation

neotheprogramist
Copy link
Contributor

No description provided.

@Okm165
Copy link
Collaborator

Okm165 commented Jan 12, 2024

we can also do some opt with passing the snapshots here for many functions WDYT?
or is it appropriate for other pr?

@neotheprogramist
Copy link
Contributor Author

@Okm165
I think we can do it in the next PR - I would opt for merging that one because it changes a repo structure a bit but there shouldn't be any conflicts with with current open PRs. Here are mainly Cargo workspace changes

@neotheprogramist neotheprogramist self-assigned this Jan 12, 2024
@neotheprogramist neotheprogramist marked this pull request as ready for review January 12, 2024 13:46
Okm165
Okm165 approved these changes Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@Okm165 Okm165 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neotheprogramist neotheprogramist merged commit c0b2fac into main Jan 15, 2024
2 checks passed
@tiagofneto tiagofneto deleted the feat/updates-and-enhancements branch January 16, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Okm165 Okm165 Okm165 approved these changes

@tiagofneto tiagofneto Awaiting requested review from tiagofneto

Assignees

@neotheprogramist neotheprogramist

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neotheprogramist @Okm165