feat/stark-commit #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neotheprogramist
force-pushed
the
feat/stark-commit
branch
2 times, most recently
from
eb43178 to
2add94d
Compare
neotheprogramist
requested review from
tiagofneto and
Okm165
and removed request for
tiagofneto
Okm165
reviewed
Jan 13, 2024
Okm165
reviewed
Jan 13, 2024
Okm165
reviewed
Jan 15, 2024
|
|
||
| proof_of_work_commit(ref channel, *unsent_commitment.proof_of_work, *config.proof_of_work); | ||
|
|
||
| StarkCommitment { |
There was a problem hiding this comment.
Given that this is the output of func it should have arrays instead of spans
WDYT?
There was a problem hiding this comment.
I've converted interaction_after_oods to Array but let's leave oods_values as Span because I would need to convert it manually to Array in the function body because it's provided as a snapshot function argument.
neotheprogramist
force-pushed
the
feat/stark-commit
branch
from
4e72b8e to
1eca072
Compare
neotheprogramist
force-pushed
the
feat/stark-commit
branch
from
1eca072 to
5a5cfb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.