Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation, Parser, FriConfig Validation Fixes #55

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

neotheprogramist
Copy link
Contributor

No description provided.

@@ -85,7 +85,6 @@ struct StarkUnsentCommitment {
struct StarkWitness {
traces_decommitment: TracesDecommitment,
traces_witness: TracesWitness,
interaction: TableCommitmentWitness,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is already fixed on stark-verify branch but we can resolve it

Copy link
Collaborator

@Okm165 Okm165 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but will have some conflicts on stark-verify

@neotheprogramist neotheprogramist merged commit 4c5514f into main Jan 10, 2024
2 checks passed
@neotheprogramist neotheprogramist deleted the feat/validation-parser-consistency branch January 10, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants