Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/stark_verify #54

Merged
merged 12 commits into from
Jan 15, 2024
Merged

feat/stark_verify #54

merged 12 commits into from
Jan 15, 2024

Conversation

Okm165
Copy link
Collaborator

@Okm165 Okm165 commented Jan 10, 2024

No description provided.

@Okm165 Okm165 marked this pull request as draft January 10, 2024 14:19
@Okm165 Okm165 self-assigned this Jan 10, 2024
@Okm165 Okm165 linked an issue Jan 10, 2024 that may be closed by this pull request
@Okm165 Okm165 changed the base branch from main to feat/tcommitment January 12, 2024 08:39
@Okm165 Okm165 changed the base branch from feat/tcommitment to main January 12, 2024 08:39
@Okm165 Okm165 marked this pull request as ready for review January 12, 2024 10:11
Copy link
Member

@fmkra fmkra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems fine, but I noticed you're using TableUnsentCommitment which I removed in #61 so we have to decide whether to keep it or get rid of.

@Okm165
Copy link
Collaborator Author

Okm165 commented Jan 13, 2024

lets get rid of it i will update my branch after we merge yours @fmkra it is just dummy struct

Copy link
Member

@fmkra fmkra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Okm165 Okm165 merged commit 71bc49b into main Jan 15, 2024
2 checks passed
@Okm165 Okm165 deleted the stark-verify branch January 15, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Develop stark-verify functionality
2 participants