Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/vcommitment #35

Merged
merged 30 commits into from
Jan 4, 2024
Merged

Feat/vcommitment #35

merged 30 commits into from
Jan 4, 2024

Conversation

fmkra
Copy link
Member

@fmkra fmkra commented Jan 3, 2024 •
edited
Loading

Implementation of vector commitment including:

  • Hashing utils
  • vector_commitment_decommit
  • vector_commit
  • validate_vector_commitment

@tiagofneto tiagofneto linked an issue Jan 3, 2024 that may be closed by this pull request
Merkle Tree / Vector Commitment #6
Closed
@fmkra fmkra marked this pull request as ready for review January 4, 2024 11:16
@fmkra fmkra requested a review from Okm165 January 4, 2024 11:16
@fmkra fmkra requested review from tiagofneto and Okm165 and removed request for Okm165 January 4, 2024 11:16
Okm165
Okm165 reviewed Jan 4, 2024
View reviewed changes
src/common/math.cairo Outdated Show resolved Hide resolved
tiagofneto
tiagofneto reviewed Jan 4, 2024
View reviewed changes
Copy link
Contributor

@tiagofneto tiagofneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, I think that the exposed interface is very easy to integrate with :)

src/vector_commitment/vector_commitment.cairo Outdated Show resolved Hide resolved
Okm165
Okm165 approved these changes Jan 4, 2024
View reviewed changes
Copy link
Collaborator

@Okm165 Okm165 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fmkra fmkra merged commit 0cab30e into main Jan 4, 2024
2 checks passed
@fmkra fmkra deleted the feat/vcommitment branch January 4, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Okm165 Okm165 Okm165 approved these changes

@tiagofneto tiagofneto tiagofneto approved these changes

Assignees

@fmkra fmkra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merkle Tree / Vector Commitment
3 participants
@fmkra @tiagofneto @Okm165