Implementation of Fast Reed-Solomon Interactive Proof of Proximity (FRIPoP) #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Okm165
changed the title
Okm165
changed the title
fmkra
reviewed
Dec 27, 2023
tiagofneto
suggested changes
Dec 27, 2023
There was a problem hiding this comment.
Overall pretty good, love the extensive testing :)
Left a couple minor comments. Also something that I noticed is that very often there are redundant imports that are already included in the prelude
fmkra
reviewed
Dec 27, 2023
fmkra
approved these changes
Dec 27, 2023
tiagofneto
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request introduces a significant enhancement to the Cairo1 verifier by implementing the Fast Reed-Solomon Interactive Proof of Proximity (FRIPoP). This enhancement is the final step in the STARK proof verification process.