Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize the auto-generated of starknet layout #149

Conversation

swift-hl
Copy link

No description provided.

@Okm165
Copy link
Collaborator

Okm165 commented Sep 12, 2024

Can u tell me what is the step drop and compiled size drop with the composition array calculations approach only.
I don't think the opt of removing trace_generator is smth we want coz it limits the verification to the certain trace size.

@swift-hl
Copy link
Author

Can u tell me what is the step drop and compiled size drop with the composition array calculations approach only. I don't think the opt of removing trace_generator is smth we want coz it limits the verification to the certain trace size.

The size of fact_registry_FactRegistry.contract_class.json has decreased from 10,298,372 to 3,961,140.

@fmkra
Copy link
Member

fmkra commented Nov 19, 2024

In latest version of integrity, we implemented splitting of autogenerated which fixes this issue. The new python script for parsing cairo0 autogenerated and outputting split cairo1 code implements similar optimizations as you did. Most cairo layouts including starknet and starknet_with_keccak are now deployed so I'm closing this pull request.

@fmkra fmkra closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants