Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

layout/starknet with keccak #116

Merged
merged 37 commits into from
Mar 27, 2024
Merged

layout/starknet with keccak #116

merged 37 commits into from
Mar 27, 2024

Conversation

Okm165
Copy link
Collaborator

@Okm165 Okm165 commented Mar 18, 2024

No description provided.

@Okm165 Okm165 self-assigned this Mar 18, 2024
@Okm165 Okm165 marked this pull request as draft March 18, 2024 15:23
@Okm165 Okm165 changed the title Feat/layout/starknet with keccak layout/starknet with keccak Mar 19, 2024
@Okm165
Copy link
Collaborator Author

Okm165 commented Mar 21, 2024

starknet_with_keccak layout not runnable in github action (due to resource consumption) suppressing it for now

@Okm165 Okm165 marked this pull request as ready for review March 21, 2024 12:46
@Okm165 Okm165 added the enhancement New feature or request label Mar 21, 2024
@Okm165 Okm165 requested a review from fmkra March 25, 2024 09:41
fmkra
fmkra approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@fmkra fmkra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please update documentation in one place

src/fri/fri_layer.cairo Outdated Show resolved Hide resolved
@Okm165 Okm165 changed the base branch from feat/layout_changer to main March 25, 2024 11:34
@Okm165 Okm165 changed the base branch from main to feat/layout_changer March 25, 2024 11:36
@Okm165 Okm165 changed the base branch from feat/layout_changer to main March 25, 2024 11:40
@Okm165 Okm165 merged commit 77f533e into main Mar 27, 2024
8 checks passed
@Okm165 Okm165 deleted the feat/layout/starknet_with_keccak branch March 27, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmkra fmkra fmkra approved these changes

Assignees

@Okm165 Okm165

Labels
enhancement New feature or request
Projects
Cairo Verifier
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Okm165 @fmkra