Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changable hasher #103

Merged
merged 21 commits into from
Feb 19, 2024
Merged

Changable hasher #103

merged 21 commits into from
Feb 19, 2024

Conversation

fmkra
Copy link
Member

@fmkra fmkra commented Feb 11, 2024

  • Merge blake2s and keccak versions into one branch
  • Add bash scripts for changing between versions

To change version run either blake.sh or keccak.sh. By default keccak is active.

@fmkra fmkra requested review from Okm165 and tiagofneto February 11, 2024 11:57
@Okm165
Copy link
Collaborator

Okm165 commented Feb 12, 2024

@fmkra pls check if os selection scripts work for u

@fmkra
Copy link
Member Author

fmkra commented Feb 12, 2024

@fmkra pls check if os selection scripts work for u

Works great

@Okm165
Copy link
Collaborator

Okm165 commented Feb 19, 2024

One minor issue persists when using keccak.sh with the native Keccak implementation: it repeatedly adds comment symbols indefinitely to the parts related to Blake2s (this renders blake2s section not changeable with blake2s.sh), and vice versa.
Hash sections itself have some comments
Do we merge it? It works if u use it correctly

@fmkra
Copy link
Member Author

fmkra commented Feb 19, 2024

Decided to ditch bash and created a python script which is much better and allows for easier expandability in the future (if we wanted to add other hashers)

Copy link
Collaborator

@Okm165 Okm165 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@fmkra fmkra merged commit bd9b253 into main Feb 19, 2024
2 checks passed
@fmkra fmkra deleted the feat/changable-hasher branch February 19, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants