Merge pull request #158 from HerodotusDev/audit

audit

src/air/layouts/_generator/main.py

@@ -512,7 +512,7 @@ def main():
 
     for layout, settings in layout_settings.items():
         handle_github_file(
-            f"https://raw.githubusercontent.com/starkware-libs/cairo-lang/master/src/starkware/cairo/stark_verifier/air/layouts/{layout}/autogenerated.cairo",
+            f"https://raw.githubusercontent.com/starkware-libs/cairo-lang/a86e92bfde9c171c0856d7b46580c66e004922f3/src/starkware/cairo/stark_verifier/air/layouts/{layout}/autogenerated.cairo",
             f"../{layout}/autogenerated.cairo",
             layout,
             settings

src/air/layouts/dex/public_input.cairo

@@ -106,10 +106,7 @@ impl DexPublicInputImpl of PublicInputTrait {
         let output_hash = poseidon_hash_span(output);
 
         // Check main page len
-        assert(
-            *memory.at(memory_index - 1) == *self.main_page.at(self.main_page.len() - 1),
-            'Invalid main page len'
-        );
+        assert(memory_index == self.main_page.len(), 'Invalid main page len');
 
         (program_hash, output_hash)
     }

src/air/layouts/recursive/public_input.cairo

@@ -106,9 +106,7 @@ impl RecursivePublicInputImpl of PublicInputTrait {
         let output_hash = poseidon_hash_span(output);
 
         // Check main page len
-        assert(
-            *memory.at(memory_index - 1) == *memory.at(memory.len() - 1), 'Invalid main page len'
-        );
+        assert(memory_index == self.main_page.len(), 'Invalid main page len');
 
         (program_hash, output_hash)
     }

src/air/layouts/recursive_with_poseidon/public_input.cairo

@@ -107,10 +107,7 @@ impl RecursiveWithPoseidonPublicInputImpl of PublicInputTrait {
         let output_hash = poseidon_hash_span(output);
 
         // Check main page len
-        assert(
-            *memory.at(memory_index - 1) == *self.main_page.at(self.main_page.len() - 1),
-            'Invalid main page len'
-        );
+        assert(memory_index == self.main_page.len(), 'Invalid main page len');
 
         (program_hash, output_hash)
     }

src/air/layouts/small/public_input.cairo

@@ -106,10 +106,7 @@ impl SmallPublicInputImpl of PublicInputTrait {
         let output_hash = poseidon_hash_span(output);
 
         // Check main page len
-        assert(
-            *memory.at(memory_index - 1) == *self.main_page.at(self.main_page.len() - 1),
-            'Invalid main page len'
-        );
+        assert(memory_index == self.main_page.len(), 'Invalid main page len');
 
         (program_hash, output_hash)
     }

src/air/layouts/starknet/public_input.cairo

@@ -107,10 +107,7 @@ impl StarknetPublicInputImpl of PublicInputTrait {
         let output_hash = poseidon_hash_span(output);
 
         // Check main page len
-        assert(
-            *memory.at(memory_index - 1) == *self.main_page.at(self.main_page.len() - 1),
-            'Invalid main page len'
-        );
+        assert(memory_index == self.main_page.len(), 'Invalid main page len');
 
         (program_hash, output_hash)
     }

src/air/layouts/starknet_with_keccak/public_input.cairo

@@ -107,10 +107,7 @@ impl StarknetWithKeccakPublicInputImpl of PublicInputTrait {
         let output_hash = poseidon_hash_span(output);
 
         // Check main page len
-        assert(
-            *memory.at(memory_index - 1) == *self.main_page.at(self.main_page.len() - 1),
-            'Invalid main page len'
-        );
+        assert(memory_index == self.main_page.len(), 'Invalid main page len');
 
         (program_hash, output_hash)
     }

src/fri/fri.cairo

@@ -115,6 +115,10 @@ fn fri_commit(
     ref channel: Channel, unsent_commitment: FriUnsentCommitment, config: FriConfig
 ) -> FriCommitment {
     assert((*config.fri_step_sizes.at(0)) == 0, 'Invalid value');
+    assert(
+        unsent_commitment.inner_layers.len().into() == config.n_layers - 1,
+        'Invalid inner layer commitments'
+    );
 
     let (commitments, eval_points) = fri_commit_rounds(
         ref channel,

src/fri/fri_config.cairo

@@ -33,6 +33,9 @@ impl FriConfigImpl of FriConfigTrait {
             *self.log_last_layer_degree_bound <= MAX_LAST_LAYER_LOG_DEGREE_BOUND, 'Value too big'
         );
         assert(*self.fri_step_sizes[0] == 0, 'Invalid value');
+        assert(
+            (*self.inner_layers).len().into() == *self.n_layers - 1, 'Invalid inner layer config'
+        );
 
         let mut i: u32 = 1;
         let n_layers: u32 = (*self.n_layers).try_into().unwrap();