Add logic to generate item links and getitemlink script command #3236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilherme-gm
changed the title
guilherme-gm
commented
Oct 6, 2023
MishimaHaruna
requested changes
Oct 14, 2023
guilherme-gm
force-pushed
the
itemlink
branch
from
26bab7e to
71b33d4
Compare
this function makes it simpler to get a value from a number script array, saving users from needing to handle the stack directly
this command creates a client-specific formatted tag with item info
guilherme-gm
force-pushed
the
itemlink
branch
from
71b33d4 to
06ed027
Compare
MishimaHaruna
approved these changes
Oct 16, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Implements the logic to generate "item links" on the server side (like when a player shift-clicks an item in-game). This uses a client-specific base62 string representing the item, refine, cards, etc.
With this PR it will be possible to create item links using script and source (which will be needed for some features)
Special thanks to Asheraf for sharing references with me for the code used in clif; Also credits to rA since I looked into some of their implementation to do this.
Issues addressed: None, I think