feature#8 #9
Open
feature#8 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssaru
reviewed
Sep 28, 2020
Comment on lines
+61
to
+71
| if results_path.exists(): | ||
| with open(results_path, mode="r") as io: | ||
| results = json.load(io) | ||
|
|
||
| result = trainer.test(runner, test_dataloaders=dataloader) | ||
| results.update({"checkpoint": args.checkpoint, f"{args.type}": result}) | ||
|
|
||
| else: | ||
| results = {} | ||
| result = trainer.test(runner, test_dataloaders=dataloader) | ||
| results.update({"checkpoint": args.checkpoint, f"{args.type}": result}) |
ssaru
reviewed
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
add src/task runner and pipeline
change train.py, evaluation.py with pytorch lightning
해당 PR을 제출하기 전에 아래 사항이 완료되었는지 확인 부탁드립니다:
1. 해당 PR은 어떤 내용인가요?
add src/task runner and pipeline
2. PR과 관련된 이슈가 있나요?