Skip to content

Commit

Permalink
added more notes, removed more summarize
Browse files Browse the repository at this point in the history
  • Loading branch information
oskar-taubert committed Sep 16, 2024
1 parent 6a7cb4a commit febbea5
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions propulate/surrogate.py
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,7 @@ def merge(self, data: np.ndarray) -> None:
self.first_run = False
return

# TODO test if this is the right way around
# Merged run's final loss is better than baseline.
if self.baseline[-1] < data[-1]:
self.baseline = data.copy()
Expand Down
4 changes: 3 additions & 1 deletion tests/test_multi_rank_workers.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,5 +84,7 @@ def test_multi_rank_workers(mpi_tmp_path: pathlib.Path) -> None:
logging_interval=10, # Logging interval
debug=1, # Debug level
)
islands.summarize(top_n=1, debug=1)
log.handlers.clear()


# TODO surrogate

0 comments on commit febbea5

Please sign in to comment.