Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #498 - Update MovieManagerUI.js #512

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

raptor-07
Copy link
Contributor

Datepicker for advanced movie options blocks out dates that it shouldn't.

'maxDate' option defaults to null.
reference: https://flatpickr.js.org/options/

The option has been removed from flatpickr instance. This allows user to select future dates.

Datepicker for advanced movie options blocks out dates that it shouldn't.

'maxDate' option defaults to null.
reference: https://flatpickr.js.org/options/

The option has been removed from flatpickr instance. This allows user to select future dates.
Copy link
Contributor

@dgarciabriseno dgarciabriseno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
Can you remove the whole onOpen function?

resources/js/Media/MovieManagerUI.js Outdated Show resolved Hide resolved
Helioviewer-Project#512 PR review suggested further changes.

doOpen handler is entirely removed
@dgarciabriseno dgarciabriseno merged commit 9bf86ec into Helioviewer-Project:main Dec 14, 2023
1 check passed
@dgarciabriseno
Copy link
Contributor

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants