Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Significantly improve this java project. #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Significantly improve this java project. #1

wants to merge 4 commits into from

Conversation

VictorVanthilt
Copy link

No description provided.

@VictorVanthilt
Copy link
Author

I have some ideas for next iterations, for example removing the README could significantly reduce the storage requirements.

maanpalle
maanpalle suggested changes May 28, 2024
View reviewed changes
Copy link

@maanpalle maanpalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the repository after this merge request is too cluttered, think about removing the README.md as well

@VictorVanthilt
Copy link
Author

Thankyou @maanpalle for your considerations. I will work on this idea when I have some free time. Right now my "rm" command is still at the repair shop. The work done in this PR significantly stressed it, the "-rf" button had to be repared.

VictorVanthilt
VictorVanthilt commented May 28, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@VictorVanthilt
Copy link
Author

@HectorPeeters Have you had the time to look at this yet?

Palle Maesen and others added 2 commits June 2, 2024 15:25
@VictorVanthilt
Copy link
Author

more gooder by bal

@VictorVanthilt
Copy link
Author

@HectorPeeters this PR has been open for quite some time now. If you are serious about improving your codebase, get to work on reviewing this PR and approving it. @maanpalle and I really worked hard on this ...

@VictorVanthilt
Copy link
Author

I think we should rethink some of the re-work. @maanpalle, @HectorPeeters are you guys down for some pair-programming next weekend?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maanpalle maanpalle Awaiting requested review from maanpalle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VictorVanthilt @maanpalle