Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: tidying up programme membership service and tests #382

Merged
merged 6 commits into from
Sep 22, 2023
Merged

chore: tidying up programme membership service and tests #382

merged 6 commits into from
Sep 22, 2023

Conversation

ReubenRobertsHEE
Copy link
Contributor

@ReubenRobertsHEE ReubenRobertsHEE commented Sep 15, 2023 •
edited
Loading

Depended on #381

TIS21-5063

@ReubenRobertsHEE ReubenRobertsHEE changed the title chore: tidying up tests chore: tidying up programme membership service and tests Sep 19, 2023
@ReubenRobertsHEE ReubenRobertsHEE force-pushed the chore/cleanupObsoleteCodeProgrammeMembershipService branch from 2456147 to 4aead9f Compare September 19, 2023 11:02
@ReubenRobertsHEE ReubenRobertsHEE force-pushed the chore/cleanupObsoleteCodeProgrammeMembershipService branch from 4aead9f to 6f5c3a0 Compare September 20, 2023 07:57
@ReubenRobertsHEE ReubenRobertsHEE marked this pull request as ready for review September 20, 2023 08:02
@ReubenRobertsHEE ReubenRobertsHEE requested a review from a team September 20, 2023 08:02
@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Judge40
Judge40 approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@Judge40 Judge40 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really glad to have that bit of code gone 😄

@ReubenRobertsHEE ReubenRobertsHEE merged commit 89c4be0 into main Sep 22, 2023
4 checks passed
@ReubenRobertsHEE ReubenRobertsHEE deleted the chore/cleanupObsoleteCodeProgrammeMembershipService branch September 22, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Judge40 Judge40 Judge40 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ReubenRobertsHEE @Judge40