feat: CoJ receivedFromTis #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TIS21-4718
|
There is a lot of obsolete code to clean-up in e.g. |
ReubenRobertsHEE
added a commit
that referenced
this pull request
Sep 13, 2023
Dependent on #380 merged, TIS CoJ DMS redrive and checks on all UUID-style PMs CoJs having receivedFromTis set. TIS21-4715
DorisWongNHS
previously approved these changes
Sep 13, 2023
| @@ -220,7 +220,7 @@ public Optional<ProgrammeMembership> signProgrammeMembershipCoj( | |||
| for (ProgrammeMembership existingProgrammeMembership : existingProgrammeMemberships) { | |||
| if (existingProgrammeMembership.getTisId().equals(programmeMembershipId)) { | |||
| ConditionsOfJoining conditionsOfJoining = | |||
| new ConditionsOfJoining(Instant.now(), GoldGuideVersion.getLatest()); | |||
| new ConditionsOfJoining(Instant.now(), GoldGuideVersion.getLatest(), null); | |||
There was a problem hiding this comment.
Setting the syncedAt' value to null here is because the CoJ has just been signed; the complete record with that value set will be received from trainee-sync once it's been saved into TCS.
|
Kudos, SonarCloud Quality Gate passed! |
|
Sorry @DorisWongNHS - I renamed the variable, so I need a re-review if that's ok 😀 |
DorisWongNHS
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TIS21-4718