Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base64 0.21, clap 4 #129

Merged
merged 3 commits into from
Nov 18, 2023
Merged

base64 0.21, clap 4 #129

merged 3 commits into from
Nov 18, 2023

Conversation

serprex
Copy link
Contributor

@serprex serprex commented Nov 6, 2023

No description provided.

Copy link
Collaborator

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for taking the time!

@jonhoo
Copy link
Collaborator

jonhoo commented Nov 11, 2023

(rebased from main which may make updating this a little annoying — sorry about that!)

Looks like rustfmt isn't quite happy with the change?

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Merging #129 (911cd13) into main (e34117e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Files Coverage Δ
src/serialization/interval_log/mod.rs 90.44% <100.00%> (+0.03%) ⬆️

@jonhoo
Copy link
Collaborator

jonhoo commented Nov 12, 2023

oof, looks like clap has bumped its MSRV to 1.70. I think the way to go about this is to do only update the lockfile to 4.3.24 with

git checkout main Cargo.lock
cargo update -p '[email protected]'

(I think that's the syntax at least)

Then, update .github/workflows/check.yml to have the MSRV be 1.64.0 (which 4.3.24 supported iiuc).

This way, consumers will get the newest version of clap, but we also ensure that there is some version of the dependencies that still build for a relatively-old version of Rust for those stuck in the past.

@jonhoo jonhoo merged commit 351e04d into HdrHistogram:main Nov 18, 2023
16 checks passed
@jonhoo
Copy link
Collaborator

jonhoo commented Nov 18, 2023

Thank you!

@jonhoo
Copy link
Collaborator

jonhoo commented Nov 18, 2023

Released in 7.5.4 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants