Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the indent options in code style settings (fixes #908) #1148

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

virtulis
Copy link
Contributor

@virtulis virtulis commented Feb 2, 2024

This is a near-exact copy of the solution proposed by @trnzk in the #908 comments, except for the added this parameter.

Unfortunately I have no experience in IDEA plugin development so can't write a proper test for this at the moment.

However I have tested it manually and verified that it works:

  • "Tabs and Indents" tab in the settings is now present.
  • Selecting "Use tab character" does switch the editor to tabs.
  • Otherwise, changing "Indent" does change the number of spaces used when reformatting.
  • If .editorconfig is present and enabled, it overrides the setting as expected (both indent_style and indent_size are obeyed).
  • Editing, code actions, refactoring, etc do seem to obey the selected settings.

@m0rkeulv m0rkeulv merged commit 2889a94 into HaxeFoundation:develop Feb 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants