Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Frame Collections not being destroyed #2929

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Fix Frame Collections not being destroyed #2929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions flixel/graphics/FlxGraphic.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,6 +516,8 @@ class FlxGraphic implements IFlxDestroyable
{
var collections:Array<Dynamic> = getFramesCollections(collection.type);
collections.push(collection);
if (!frameCollectionTypes.contains(collection.type))
frameCollectionTypes.push(collection.type);
}
}

Expand Down
6 changes: 0 additions & 6 deletions flixel/graphics/frames/FlxImageFrame.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,12 +245,6 @@ class FlxImageFrame extends FlxFramesCollection
return imageFrame;
}

override public function destroy():Void
{
super.destroy();
FlxDestroyUtil.destroy(frame);
}

function get_frame():FlxFrame
{
return frames[0];
Expand Down
Loading