Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changes to referral fee percentage on the implementation #2

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

spengrah
Copy link
Member

This PR allows the referrer to update the referral fee percentage. The change is made to the implementation contract state, and is only applied to module instances deployed after the change. Referral fee percentage for instances deployed prior to the change will not change.

Copy link

Changes to gas cost

Generated at commit: 7e9c266aba99f209e69db94fcd49ef974279f476, compared to commit: f7259a5d2e7e19d1d67cf643b4cd86e7c6ae41e8

🧾 Summary (10% most significant diffs)

Contract Method Avg (+/-) %
DeployInstance prepare
run
-6,347 ✅
+20,847 ❌
-4.07%
+1.64%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
DeployInstance 1,219,803 (-18,020) prepare
run
50,358 (-105,751)
1,276,125 (+3,900)
-67.74%
+0.31%
149,762 (-6,347)
1,293,072 (+20,847)
-4.07%
+1.64%
150,658 (-5,451)
1,293,225 (+21,000)
-3.49%
+1.65%
150,658 (-5,451)
1,293,225 (+21,000)
-3.49%
+1.65%
112 (+96)
112 (+96)

@spengrah spengrah marked this pull request as ready for review September 11, 2024 20:07
@spengrah spengrah requested a review from gershido September 11, 2024 20:07
Copy link

@gershido gershido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@spengrah spengrah merged commit 3b043fd into main Sep 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants