Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update index.html #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update index.html #77

wants to merge 1 commit into from

Conversation

Atharva089
Copy link

Type of change

Update the index.html in the ng-select2/src/ folder.

Details

As asked in the issue, I had to make necessary changes into the index.html file

Before update

The head and the body tags of the file before making changes.

<head>
    <meta charset="utf-8" />
    <title>NgSelect2</title>
    <base href="./" />

    <meta name="viewport" content="width=device-width, initial-scale=1" />
    <link rel="icon" type="image/x-icon" href="favicon.ico" />
</head>

<body>
    <app-root></app-root>
</body>

After update

The head and the body tags of the file before making changes.

<title>NgSelect2</title> 
    <meta name="viewport" content="width=device-width, initial-scale=1" />
    <link rel="icon" type="image/x-icon" href="favicon.ico" />

    <!-- Include Bootstrap CSS -->
    <link
        href="https://cdn.jsdelivr.net/npm/[email protected]/dist/css/bootstrap.min.css"
        rel="stylesheet"
    />

    <script
        src="https://cdn.jsdelivr.net/npm/[email protected]/dist/js/bootstrap.bundle.min.js"
        defer
    ></script>
</head>

<body>
    <app-root></app-root>
</body>

@Harvest-Dev please review this pull request and merge it to solve the issue #76

@Atharva089
Update index.html
495e7c2 
Added Bootstrap's CSS and JavaScript files to the index.html to enable Bootstrap styling, allowing to use Bootstrap classes in components.
@Zefling
Copy link
Collaborator

Zefling commented Nov 28, 2024

Sorry for not saying anything until now.
But I don't understand the use of PR.
The idea would be to make a theme for bootstrap, not to use Bootstrap for the demo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Atharva089 @Zefling