Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/misc paper updates #69

Merged
merged 46 commits into from
Jun 3, 2024
Merged

Dev/misc paper updates #69

merged 46 commits into from
Jun 3, 2024

Conversation

nickkamp1
Copy link
Collaborator

@nickkamp1 nickkamp1 commented May 16, 2024

This branch includes many updates that get the codebase ready for the first paper. These include

  • Removing hard dependence on DarkNews (now optional)
  • Fixing serialization routines for the new injector class and making sure we can actually save and load injector objects
  • Updating the controller object to be able to reweight previously generated events to new physical distributions
  • Make it possible to serialize vectors of interaction trees
  • Make a number of updates to the paper plot notebooks to get figures ready for the paper
  • Some renaming of objects for coherence
  • Make it possible for the Weighter objects to use different interaction collections for the injection and physical processes
  • Add hyperk

Remaining tasks:

  • Make sure serialization of injectors works when they include a pyDarkNews[] object, I don't think this currently works
  • Fix serialization for TreeWeighter, currently experiencing compilation errors

This PR is probably now ready for review, we should merge and submit the paper!

nickkamp1 and others added 17 commits March 28, 2024 17:26
…ngs with new serialization scheme for trampoline classes
…the controller to be able to load interaction trees and reweight them to new physical distributions. Ensure this works for the DIS example, update the appendix plots notebooks to use this functionality
@nickkamp1 nickkamp1 requested a review from austinschneider May 16, 2024 22:49
@austinschneider austinschneider merged commit c02f1b4 into main Jun 3, 2024
49 checks passed
@austinschneider austinschneider deleted the dev/misc_paper_updates branch October 18, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants