Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python data #48

Merged
merged 15 commits into from
Jan 24, 2024
Merged

Python data #48

merged 15 commits into from
Jan 24, 2024

Conversation

austinschneider
Copy link
Collaborator

This PR aims to improve how we are packaging our data.

The main goals are:

  • Have the package reference data from its resources directory
  • Store generated data from DarkNews in the resources directory
  • Version the cross sections, detector models, etc.
  • Create a system for managing versions of these models in the context of the LIController and any other methods that perform some sort of automatic/default setup procedure

@austinschneider austinschneider self-assigned this Jan 24, 2024
@austinschneider austinschneider added the enhancement New feature or request label Jan 24, 2024
@austinschneider austinschneider marked this pull request as ready for review January 24, 2024 03:26
@austinschneider
Copy link
Collaborator Author

Something is causing the artifact upload stage of the build_wheel jobs to fail, so I don't think the failures are related to anything in the code. I'm assuming the issue was some transient problem with github, so just going to restart the failed jobs until they finish. Otherwise I think this PR is good to go!

Copy link
Collaborator

@nickkamp1 nickkamp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most recent commit ensures that cross section tables are being saved correctly for the DarkNews examples. Fixes bugs not related to this PR. Changes directly related to this PR all look good, approving

@austinschneider austinschneider merged commit de8c22e into main Jan 24, 2024
1 of 14 checks passed
@austinschneider austinschneider deleted the dev/python_data branch October 18, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants