Upgrade quickjs version to 2024-0214

[HarlonWang]

Upgrade quickjs version to 2024-0214

Sourcery总结

将QuickJS库升级到版本2024-0214，并通过删除冗余测试和更新断言以提高准确性来优化测试套件。

增强功能：

• 将QuickJS版本更新到2024-0214，确保项目使用QuickJS库的最新功能和改进。

测试：

• 删除与QuickJS中函数调用错误相关的过时或冗余的测试用例，简化测试套件。
• 修改QuickJSModuleTest中的测试断言，以检查Promise对象而不是null，提高测试准确性。

Original summary in English

Summary by Sourcery

Upgrade the QuickJS library to version 2024-0214 and refine the test suite by removing redundant tests and updating assertions for better accuracy.

Enhancements:

• Update the QuickJS version to 2024-0214, ensuring the project uses the latest features and improvements from the QuickJS library.

Tests:

• Remove outdated or redundant test cases related to function invocation errors in QuickJS, streamlining the test suite.
• Modify a test assertion in QuickJSModuleTest to check for a Promise object instead of null, improving test accuracy.

[sourcery-ai]

Sourcery 的审查指南

此拉取请求将 QuickJS 版本升级到 2024-0214。更改主要涉及删除过时的测试用例和调整现有测试以符合新的 QuickJS 行为。

文件级更改

更改	详情	文件
删除过时的测试用例	删除了 'testNotAFunction' 测试方法 删除了 'testNotAFunction2' 测试方法 删除了 'testNotAFunctionInPromise' 测试方法	wrapper-android/src/androidTest/java/com/whl/quickjs/wrapper/QuickJSTest.java
更新模块测试中的断言	将断言从 assertNull 改为 assertEquals 现在期望返回值为 '[object Promise]'	wrapper-android/src/androidTest/java/com/whl/quickjs/wrapper/QuickJSModuleTest.java
CMakeLists.txt 中的小改动	在文件末尾添加了一个换行符	wrapper-java/src/main/CMakeLists.txt

---

提示

• 通过在拉取请求中评论 @sourcery-ai review 来触发新的 Sourcery 审查。
• 通过直接回复审查评论继续与 Sourcery 的讨论。
• 您可以随时通过访问您的仪表板更改您的审查设置：
  • 启用或禁用 Sourcery 生成的拉取请求摘要或审查指南；
  • 更改审查语言；
• 如果您有任何问题或反馈，您可以随时联系我们。

Original review guide in English

Reviewer's Guide by Sourcery

This pull request upgrades the QuickJS version to 2024-0214. The changes primarily involve removing outdated test cases and adjusting existing tests to align with the new QuickJS behavior.

File-Level Changes

Change	Details	Files
Removal of outdated test cases	Removed the 'testNotAFunction' test method Removed the 'testNotAFunction2' test method Removed the 'testNotAFunctionInPromise' test method	wrapper-android/src/androidTest/java/com/whl/quickjs/wrapper/QuickJSTest.java
Updated assertion in module test	Changed assertion from assertNull to assertEquals Now expecting '[object Promise]' as the return value	wrapper-android/src/androidTest/java/com/whl/quickjs/wrapper/QuickJSModuleTest.java
Minor change in CMakeLists.txt	Added a newline at the end of the file	wrapper-java/src/main/CMakeLists.txt

---

Tips

• Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
• Continue your discussion with Sourcery by replying directly to review comments.
• You can change your review settings at any time by accessing your dashboard:
  • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
  • Change the review language;
• You can always contact us if you have any questions or feedback.

[sourcery-ai]

嗨 @HarlonWang - 我已经审查了你的更改 - 这里有一些反馈：

总体评论：

• 在 QuickJSTest.java 中删除大量测试用例令人担忧。请提供这些测试不再需要的理由。
• 拉取请求描述缺乏细节。你能否详细说明此次升级的原因和预期的好处？

这是我在审查期间查看的内容

• 🟢 一般问题：一切看起来都很好
• 🟢 安全性：一切看起来都很好
• 🟢 测试：一切看起来都很好
• 🟢 复杂性：一切看起来都很好
• 🟢 文档：一切看起来都很好

---

Sourcery 对开源项目免费 - 如果你喜欢我们的评论，请考虑分享它们 ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{帮助我变得更有用！请点击 👍 或 👎 来告诉我每条评论是否有帮助。}

Original comment in English

Hey @HarlonWang - I've reviewed your changes - here's some feedback:

Overall Comments:

• The removal of a large number of test cases in QuickJSTest.java is concerning. Please provide justification for why these tests are no longer needed.
• The pull request description lacks detail. Could you elaborate on the reasons for this upgrade and the expected benefits?

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}