Legacy Sheet Compatibility and Bugfixes #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eing declared twice.
…mina Check roll button is clickable, not just the text label in the centre.
…ab to the actor sheet. Now falls back to the legacy sheet area names.
…udimentary series of Try/Catch to ignore errors in code that expects the new sheet. This should probably be improved further.
…me validation when searching for the area to place the Wounds section. It falls back to the Legacy .counters section, or if nothing can be found, defaults to the darker dungeons tab itself. (This gives some compatibility with custom sheets, which should always have the dd tab. Tested only with Compact D&D Beyond sheet). Cleaned up some test logging.
…on reading "ReopenReopen Wounds" when hovered. It's obviously here for a reason so I might just have misunderstood how it should work, or somehow caused the bug in the first place, but this fixes it for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Handyfon, recently discovered DarkerDungeons and wanted to use it in Foundry. I found and loved this module you made, but came across a few bugs, as well as wanting to use the Legacy sheet or Compact D&D Beyond sheet. I've put together a few bugfixes and compatibility tweaks to make your module's content show up on the Legacy, and Compact D&D Beyond sheets.
I'm not really a javascript dev, and it's my first time editing a Foundry module so hopefully my changes seem rational, let me know if anything is amiss. The Legacy compatibility is definitly a bit rough, but it at least provides the functionality.
Legacy Sheet Compatibility:
Added rudimentry validation when searching for elements to add content to. If the new sheet locations cannot be found, it falls back to using the Legacy sheet locations.
Bugfixes: