Fix a UI-off-main-thread bug

Hammerspoon · Nov 14, 2024 · 4a4f0ce · 4a4f0ce
1 parent e9c0559
commit 4a4f0ce
Showing 1 changed file with 9 additions and 8 deletions.
diff --git a/Hammerspoon/MJPreferencesWindowController.m b/Hammerspoon/MJPreferencesWindowController.m
@@ -67,16 +67,17 @@ - (void) reflectDefaults {
 }
 
 - (void)updateFeedbackDisplay:(NSNotification __unused *)notification {
-    [self.openAtLoginCheckbox setState:MJAutoLaunchGet() ? NSControlStateValueOn : NSControlStateValueOff];
-    [self.showDockIconCheckbox setState: MJDockIconVisible() ? NSControlStateValueOn : NSControlStateValueOff];
-    [self.showMenuIconCheckbox setState: MJMenuIconVisible() ? NSControlStateValueOn : NSControlStateValueOff];
-    [self.keepConsoleOnTopCheckbox setState: MJConsoleWindowAlwaysOnTop() ? NSControlStateValueOn : NSControlStateValueOff];
-    [self.uploadCrashDataCheckbox setState: HSUploadCrashData() ? NSControlStateValueOn : NSControlStateValueOff];
+    dispatch_async(dispatch_get_main_queue(), ^{
+        [self.openAtLoginCheckbox setState:MJAutoLaunchGet() ? NSControlStateValueOn : NSControlStateValueOff];
+        [self.showDockIconCheckbox setState: MJDockIconVisible() ? NSControlStateValueOn : NSControlStateValueOff];
+        [self.showMenuIconCheckbox setState: MJMenuIconVisible() ? NSControlStateValueOn : NSControlStateValueOff];
+        [self.keepConsoleOnTopCheckbox setState: MJConsoleWindowAlwaysOnTop() ? NSControlStateValueOn : NSControlStateValueOff];
+        [self.uploadCrashDataCheckbox setState: HSUploadCrashData() ? NSControlStateValueOn : NSControlStateValueOff];
 #ifndef SENTRY_API_URL
-    [self.uploadCrashDataCheckbox setState:NSControlStateValueOff];
-    [self.uploadCrashDataCheckbox setEnabled:NO];
+        [self.uploadCrashDataCheckbox setState:NSControlStateValueOff];
+        [self.uploadCrashDataCheckbox setEnabled:NO];
 #endif
-
+    });
 }
 
 - (void) showWindow:(id)sender {