Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ReadWriteMultipleRegister support #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix ReadWriteMultipleRegister support #6

wants to merge 3 commits into from

Commits on Apr 20, 2023

  1. AbstractModbusMessage: make MessageFrame virtual 

    so it can be overridden by classes which need to override ProtocolDataUnit
    @pieterg
    pieterg authored Apr 20, 2023
    Configuration menu
    Copy the full SHA
    cbca546 View commit details
    Browse the repository at this point in the history

  2. ReadWriteMultipleRegistersRequest: override MessageFrame 

    When using the base class MessageFrame implementation, it will call the base class ProtocolDataUnit, resulting in an invalid/incomplete message frame.
By overriding MessageFrame,  our overridden ProtocolDataUnit will be called instead.
    @pieterg
    pieterg authored Apr 20, 2023
    Configuration menu
    Copy the full SHA
    833690f View commit details
    Browse the repository at this point in the history

  3. ModbusRtuTransport: fix handling ReadWriteMultipleRegisters response 

    ReadWriteMultipleRegisters response is the same as a ReadHoldingRegisters response
    @pieterg
    pieterg authored Apr 20, 2023
    Configuration menu
    Copy the full SHA
    41ecd05 View commit details
    Browse the repository at this point in the history