-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version with lots of improvements #15
Conversation
Src/Headers/TButton.h
Outdated
@@ -11,11 +11,12 @@ | |||
#include <File.h> | |||
#include <String.h> | |||
#include <vector> | |||
using namespace std; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to use using std::vector
.
Src/Headers/TexBar.h
Outdated
@@ -11,9 +11,11 @@ | |||
#include <ScrollBar.h> | |||
#include <InterfaceDefs.h> | |||
#include <vector> | |||
using namespace std; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
@Sylvain78 , Also see #14 there is a source zip file on the linked page there. To me it looks like an earlier rev. But the poster say that version is more stable. You might check it to see if there is anything on use in that source zip. If you check it over, you might comment on that issue regarding what you find and maybe we can close that one out. |
Also, I see you did your work in master. We prefer you follow the HaikuPorts/HaikuArchives development model: Don't worry about it for this PR, but once this gets merged, start doing future work in feature branches. After you do a few Pull Requests following this model you will get the hang of how it works. |
Ultimately it does not make much of a difference what branch a PR comes from for us; it just makes it easier on the person sending PRs to reset state once the PR has been merged. |
Makefile
Outdated
Src/Source/Prefs.cpp \ | ||
Src/Source/PrefsListItem.cpp \ | ||
Src/Source/PrefsListView.cpp \ | ||
Src/Source/PrefsWindow.cpp | ||
|
||
# Specify the resource definition files to use. Full or relative paths can be | ||
# used. | ||
RDEFS = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switch to use the rdef instead of rsrc"
RDEFS = BeTeX.rdef
RSRC =
and then you can delete the BeTeX.rsrc file from the repo, it would be regenerated when running make.
Any progress here? With the open PR at haikuports (and the above fix for 32bit) it builds OK and works fine, current version doesn't let me open tex files, with these changes (and the work done on texlive/latex2html) it works quite well. |
What's the status on this one? Do these changes still work, what is left to be done? Is this ready for merge? |
Patch doesn't apply, getting fails on Makefile (did a srcGitRev with latest commit and this PR as a patch) |
44dc972
to
e889633
Compare
Improvements.
Tested on x86_gcc2 and x86 ,bare metal installation