Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unified alerting support #175

Merged
merged 4 commits into from
Nov 3, 2023
Merged

Unified alerting support #175

merged 4 commits into from
Nov 3, 2023

Conversation

unflag
Copy link
Collaborator

@unflag unflag commented Oct 14, 2023 •
edited
Loading

  • Supported unified alerting including time range variables interpolation for alerting queries. To achieve that:
  • Moved range variable interpolation to backend to avoid logic duplication
  • Minor fixes and typo corrections
  • README.md updated

Fixes #158

@unflag unflag requested a review from HadesArchitect October 14, 2023 22:35
@unflag unflag force-pushed the feature/unified-alerting-support branch from 610c703 to a8a8b9a Compare October 14, 2023 22:51
@unflag unflag force-pushed the feature/unified-alerting-support branch from a8a8b9a to e33d252 Compare October 15, 2023 11:54
@unflag unflag force-pushed the feature/unified-alerting-support branch from e33d252 to b33727e Compare October 15, 2023 12:13
HadesArchitect
HadesArchitect approved these changes Oct 16, 2023
View reviewed changes
Copy link
Owner

@HadesArchitect HadesArchitect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@HadesArchitect HadesArchitect marked this pull request as draft October 16, 2023 10:45
@HadesArchitect HadesArchitect added this to the 3.0.0 milestone Oct 16, 2023
@unflag unflag force-pushed the feature/unified-alerting-support branch 5 times, most recently from df3671f to c6cd6d0 Compare October 22, 2023 10:45
@unflag unflag self-assigned this Oct 22, 2023
@unflag unflag force-pushed the feature/unified-alerting-support branch from c6cd6d0 to 96afa7a Compare October 23, 2023 11:12
@unflag unflag force-pushed the feature/unified-alerting-support branch from 96afa7a to b05d1ac Compare October 24, 2023 18:25
@unflag unflag marked this pull request as ready for review October 26, 2023 22:18
@unflag unflag force-pushed the feature/unified-alerting-support branch from 4f81f3a to 79e15b2 Compare October 26, 2023 22:26
@unflag
Copy link
Collaborator Author

unflag commented Oct 26, 2023

@HadesArchitect
Looks like I fixed everything here including alerting issue with incorrect query type. Could you check PR again just to be sure?

@unflag unflag requested a review from HadesArchitect October 26, 2023 22:35
HadesArchitect
HadesArchitect approved these changes Nov 3, 2023
View reviewed changes
Copy link
Owner

@HadesArchitect HadesArchitect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HadesArchitect HadesArchitect merged commit 2df4bd7 into HadesArchitect:main Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@futuarmo futuarmo futuarmo approved these changes

@HadesArchitect HadesArchitect HadesArchitect approved these changes

Assignees

@unflag unflag

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

[Alerting] Error parsing $__timeFrom and $__timeTo
3 participants
@unflag @HadesArchitect @futuarmo