Fixes #14461 - fix: make sync button get member data is user is in a party #14468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashbork
changed the title
|
Simple and clean! It does mean an extra API call for each manual sync when a user's in a party, but I think that's acceptable to meet user expectations for how the sync button should work. If you have a Habitica User ID, let us know so we can give you contributor credit on the site! Either way, thank you for the PR! |
|
Sure! My user ID is |
|
How are we doing with the merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14461
Changes
A simple fix for the issue; after the fetch, if the user is in a party, member stats are also fetched on sync. This lets stats such as mana and EXP be synced without reloading the whole app.