Add a github action for setting up test environment and running the tests #31
Conversation
culka
force-pushed
the
e2e-test-action
branch
2 times, most recently
from
d945f9b to
b4db0e2
Compare
| @@ -11,20 +11,11 @@ jobs: | |||
| runs-on: ubuntu-latest-4-cores | |||
|
|
|||
| steps: | |||
| # We need to checkout code in order to run a local action | |||
| - name: Checkout code | |||
There was a problem hiding this comment.
Shouldn't this "Checkout code" step be removed because it is part of run-ci?
An old version of the action is used by the way.
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @jarkkoka)
.github/workflows/test-run-cypress-tests-action.yml line 15 at r1 (raw file):
Previously, jarkkoka (Jarkko Kaura) wrote…
Shouldn't this "Checkout code" step be removed because it is part of
run-ci?An old version of the action is used by the way.
As the comment above says, an action in the same repository cannot be used without doing a checkout first. It won't be needed when using the action from another Github repository.
Updated the version!
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @culka)
.github/workflows/test-run-cypress-tests-action.yml line 15 at r1 (raw file):
Previously, culka (Teemu Mäkinen) wrote…
As the comment above says, an action in the same repository cannot be used without doing a checkout first. It won't be needed when using the action from another Github repository.
Updated the version!
Ok. Couldn't interpret the comment correctly.
.github/workflows/test-run-cypress-tests-action.yml line 14 at r3 (raw file):
steps: # We need to checkout code in order to run a local action
IMO "local action" is not something easily understood. For me ,"local action" means something that is run on the developer's own computer. See e.g. https://github.com/github/local-action
I'd add the following sentence here:
Even though code checking is part of the "run-ci" action, it must be done separately here, because "run-ci" is located in this same repository.
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @culka)
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @jarkkoka)
.github/workflows/test-run-cypress-tests-action.yml line 14 at r3 (raw file):
Previously, jarkkoka (Jarkko Kaura) wrote…
IMO "local action" is not something easily understood. For me ,"local action" means something that is run on the developer's own computer. See e.g. https://github.com/github/local-action
I'd add the following sentence here:
Even though code checking is part of the "run-ci" action, it must be done separately here, because "run-ci" is located in this same repository.
Using this one 🙂
This change is