Change database user in application configuration #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarkkoka
force-pushed
the
change-db-user-in-default-config
branch
5 times, most recently
from
d4d7525 to
1aa1028
Compare
culka
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Reviewed 8 of 10 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jarkkoka)
The change is done in order to spot possible database permission issues. Also, remove defaulting to Hasura user in Docker setup. Resolves HSLdevcom/jore4#1551
jarkkoka
force-pushed
the
change-db-user-in-default-config
branch
from
1aa1028 to
b883204
Compare
jarkkoka
commented
Oct 19, 2023
There was a problem hiding this comment.
Reviewable status: 5 of 12 files reviewed, 1 unresolved discussion (waiting on @culka)
script/build-jdbc-urls.sh line 12 at r3 (raw file):
export JORE4_DB_PORT=${JORE4_DB_PORT:-"5432"} export JORE4_DB_DATABASE=${JORE4_DB_DATABASE:-"timetablesdb"} export JORE4_DB_URL="jdbc:postgresql://${JORE4_DB_HOSTNAME}:${JORE4_DB_PORT}/${JORE4_DB_DATABASE}?stringtype=unspecified"
These changes are important to prevent using incorrect settings in the Azure environment that are intended for local development.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change is done in order to spot possible database permission issues. Also, remove defaulting to Hasura user in Docker setup.
Continue to use the Hasura user for integration tests, as Data-Inserter needs permissions to execute
TRUNCATESQL commands to the database.This change is