[fix][broker]unify time unit at dropping the backlog on a topic #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apache#17541) * [ci] Reduce runners load for pulls that affects only doc or cpp changes * add final jobs to mark required workflows as completed even if they are skipped * test parametrized job id * fix latest step
- to reduce load on CI
…che#17551) * [ci] Skip run flaky tests suite for cpp-only changes * also ignore doc changes * use changed_files
…le after 10 minutes (apache#17401) * [fix][broker] Leader election cache should not invalidate entries - cache expiration leads to problems and it is better to serve a stale entry than to ever expire the entry - MetadataStore didn't support passing cache configuration for a MetadataCache, it was necessary to modify the interface to support that. * Add test case * Prevent stale values in leader election cache Co-authored-by: Enrico Olivelli <[email protected]>
* [improve][misc] Pull request template 1. Highlight to retain the documentation section so that committers can correct it if necessary simply with UI. 2. Few people edit the "affect one of the following parts". Change it to checkboxes for easily applying. 3. Comment out some placeholder. * Update .github/PULL_REQUEST_TEMPLATE.md
* remove `This example uses Pulsar x.x.x` * Update site2/docs/tiered-storage-aliyun.md Co-authored-by: momo-jun <[email protected]> * Update site2/docs/tiered-storage-aws.md Co-authored-by: momo-jun <[email protected]> * Update site2/docs/tiered-storage-filesystem.md Co-authored-by: momo-jun <[email protected]> * Update site2/docs/tiered-storage-azure.md Co-authored-by: momo-jun <[email protected]> * Update site2/docs/tiered-storage-gcs.md Co-authored-by: momo-jun <[email protected]> Co-authored-by: momo-jun <[email protected]>
* WIP:move cluster-level failover * update * Update site2/docs/client-libraries-java.md Co-authored-by: momo-jun <[email protected]> * Update site2/docs/concepts-cluster-level-failover.md Co-authored-by: momo-jun <[email protected]> * improve doc Co-authored-by: momo-jun <[email protected]>
…d topic with active consumer leaves topic metadata inconsistent. (apache#17308)" (apache#17566) This reverts commit 9529850.
Master Issue: apache#16912 Remove `WhiteBox` usage in `pulsar-client` and `pulsar-client-tools`. We then have only usages in `pulsar-broker`, `pulsar-io-elastic-search`, and `testmocks`. cc @nicoloboschi @lhotari @shoothzj @eolivelli ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc-required` (Your PR needs to update docs and you will update later) - [x] `doc-not-needed` (Please explain why) - [ ] `doc` (Your PR contains doc changes) - [ ] `doc-complete` (Docs have been already added)
…s` greater than `maxUnackedMessages` (apache#17483)
…sk space issue in saving docker image (apache#17584) * [fix][CI] Don't run "Pulsar CI checks completed" too early - "if: always()" caused the job to run also when something failed * Clean up disk space in "Build Pulsar docker image" * Show disk space before and after cleaning * Fix deleting files
) Master Issue: apache#16912 ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc-required` (Your PR needs to update docs and you will update later) - [x] `doc-not-needed` (Please explain why) - [ ] `doc` (Your PR contains doc changes) - [ ] `doc-complete` (Docs have been already added)
* improve issue templates wordings Signed-off-by: tison <[email protected]> * Skip tests for issue template or changes-filter.yaml changes Signed-off-by: tison <[email protected]> Co-authored-by: Lari Hotari <[email protected]>
…invalid property name (apache#17930) * [fix][testclient] Fix proxyProtocol parsing when value is empty, fix invalid property name
…#17935) Fixes apache#17786 ### Motivation * We want to make compatibility table single source because it is hard to keep all of them up-to-date. ### Modifications * Make node and c++ client compatibility table a link to github.
* [cleanup] reference to C++ and Python client Signed-off-by: tison <[email protected]> * address comments Signed-off-by: tison <[email protected]> Signed-off-by: tison <[email protected]>
…tTest (apache#17934) - fix thread safety issues with SimpleConsumerSocket and SimpleProducerSocket
* [improve][doc] add developers-landing page The Pulsar for Developers content block on the documentation landing page needs to link to this page. * Update getting-started-standalone.md * Update getting-started-standalone.md * move the file to /site2/docs/ * Update about.md * Update site2/docs/developers-landing.md Co-authored-by: tison <[email protected]> * Update site2/docs/getting-started-standalone.md Co-authored-by: tison <[email protected]> * [doc][improve] Update concepts-messaging.md Minor content edits, add / replace images to improve clarity and consistency. * Update site2/docs/concepts-messaging.md Co-authored-by: Anonymitaet <[email protected]> Co-authored-by: momo-jun <[email protected]> Co-authored-by: tison <[email protected]> Co-authored-by: Anonymitaet <[email protected]>
5 tasks
|
/pulsarbot run-failure-checks |
2 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
Signed-off-by: Zixuan Liu <[email protected]>
|
The pr had no activity for 30 days, mark with Stale label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The backlog quota in time does not work due to time unit inconsistency in dropping the backlog on a topic.
The unit of backlog quota limit in time is seconds.
https://github.com/apache/pulsar/blob/8d13ff81108b95ae5f63245e4a5edf4e097aaf47/pulsar-client-admin-api/src/main/java/org/apache/pulsar/common/policies/data/BacklogQuota.java#L47-L52
The time unit inconsistency is here as follows.
https://github.com/apache/pulsar/blob/8d13ff81108b95ae5f63245e4a5edf4e097aaf47/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BacklogQuotaManager.java#L221-L224
Modifications
unify time unit.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-requireddoc-not-neededdocdoc-completeMatching PR in forked repository
PR in forked repository: #3