Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#44351 #98

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

#44351 #98

wants to merge 2 commits into from

Conversation

IrfanH99
Copy link

Updated the value data type to "dateTime" instead of "date" as per the disposition comment.

Updated the value data type to "dateTime" instead of "date" as per the disposition comment
Copy link
Contributor

@lmckenzi lmckenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change also happening to the Metadata resource? The point of this extension is to align with that resource. This is also a breaking change to the extension. Are we 100% positive that no-one is using it so far? I think this should probably be handled by deprecating publish-date and adding publish-datetime.

Updated to include the deprecated extension on the "date" datatype. Will add a new ticket for the MetadataResource tomorrow.
@grahamegrieve
Copy link
Contributor

grahamegrieve commented Apr 24, 2024

What committee approved this? And where's the minutes? Why was this change considered justified - these things usually are dates, and it's hard to think that this changes more than once a day in aw ay that needs tracking.

@sheridancook
Copy link
Contributor

@grahamegrieve - it went to CDS. Jira indicates Vote was: Greg White/Jen Seeman: 13-0-1
Had a chance to touchbase with this briefly with Lloyd - we know we'll have to submit a subsequent ticket for Metadata resource to keep them in sync, the original intent was to see greater consistency in similar extensions on meta and metadataresource that are still in draft status (i.e., if Meta deals with instants, and it's extensions deal in instant and dateTime data types...and publication systems are configured against those datatypes - is metadataresource & its extensions unnecessarily different)

@grahamegrieve
Copy link
Contributor

Well, I think this is a problem, because this can't change in the existing normative metadata resources such as CodeSystem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants