Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds can history query and renders to can details page #3345

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat: adds can history query and renders to can details page #3345

wants to merge 9 commits into from

Conversation

fpigeonjr
Copy link
Contributor

@fpigeonjr fpigeonjr commented Jan 22, 2025 •
edited
Loading

What changed

  • adds CAN history FE component

Issue

#2680 #3342

How to test

  1. e2e tests pass or:
  2. Goto /cans/500
  3. see history panel
  4. scroll down
  5. should see 12 items
  6. 💰profit

Screenshots

image

Definition of Done Checklist

  • OESA: Code refactored for clarity
  • OESA: Dependency rules followed
  • Automated unit tests updated and passed
  • Automated integration tests updated and passed
  • Automated quality tests updated and passed
  • Automated load tests updated and passed
  • Automated a11y tests updated and passed
  • Automated security tests updated and passed
  • 90%+ Code coverage achieved
  • [ ] Form validations updated

@fpigeonjr fpigeonjr changed the title feat: adds can history query and renders to can detais page feat: adds can history query and renders to can details page Jan 22, 2025
@fpigeonjr fpigeonjr added the javascript Pull requests that update Javascript code label Jan 22, 2025
@fpigeonjr fpigeonjr marked this pull request as ready for review January 24, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Santi-3rd Santi-3rd Awaiting requested review from Santi-3rd

@johndeange johndeange Awaiting requested review from johndeange

@maiyerlee maiyerlee Awaiting requested review from maiyerlee

@weimiao67 weimiao67 Awaiting requested review from weimiao67

@jonnalley jonnalley Awaiting requested review from jonnalley

@rajohnson90 rajohnson90 Awaiting requested review from rajohnson90

At least 3 approving reviews are required to merge this pull request.

Assignees

@fpigeonjr fpigeonjr

@maiyerlee maiyerlee

@weimiao67 weimiao67

Labels
javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fpigeonjr @maiyerlee @weimiao67