Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ✨ adds prev fy carry forward card #3300

Merged
merged 6 commits into from
Jan 16, 2025
Merged

feat: ✨ adds prev fy carry forward card #3300

merged 6 commits into from
Jan 16, 2025

Conversation

fpigeonjr
Copy link
Contributor

@fpigeonjr fpigeonjr commented Jan 13, 2025 •
edited
Loading

What changed

  • adds prev fy carry forward card

Issue

#310 #3236

How to test

  1. watch e2e tests pass or:
  2. goto cans/504/funding
  3. click edit
  4. see FY carry forward card
  5. goto cans/500/funding
  6. click edit
  7. DO NOT see FY carry forward card
  8. 💰profit

Screenshots

image

Definition of Done Checklist

  • OESA: Code refactored for clarity
  • OESA: Dependency rules followed
  • Automated unit tests updated and passed
  • Automated integration tests updated and passed
  • Automated quality tests updated and passed
  • Automated load tests updated and passed
  • Automated a11y tests updated and passed
  • Automated security tests updated and passed
  • 90%+ Code coverage achieved
  • [ ] Form validations updated

@fpigeonjr fpigeonjr marked this pull request as ready for review January 14, 2025 14:36
@fpigeonjr fpigeonjr added the javascript Pull requests that update Javascript code label Jan 14, 2025
@fpigeonjr fpigeonjr merged commit bffe70a into main Jan 16, 2025
42 checks passed
@fpigeonjr fpigeonjr deleted the OPS-310/3236_prev_FY_carry_forward_card branch January 16, 2025 14:18
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.22.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maiyerlee maiyerlee maiyerlee approved these changes

@rajohnson90 rajohnson90 rajohnson90 approved these changes

@johndeange johndeange johndeange approved these changes

@weimiao67 weimiao67 Awaiting requested review from weimiao67

@jonnalley jonnalley Awaiting requested review from jonnalley

@Santi-3rd Santi-3rd Awaiting requested review from Santi-3rd

Assignees

@fpigeonjr fpigeonjr

@maiyerlee maiyerlee

@weimiao67 weimiao67

Labels
javascript Pull requests that update Javascript code released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fpigeonjr @johndeange @rajohnson90 @maiyerlee @weimiao67