Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement module-theta readout (with per-layer merging) #46

Merged

Conversation

giovannimarchiori
Copy link
Contributor

@giovannimarchiori giovannimarchiori commented Aug 28, 2023

This code implements the RedoSegmentation method for the module-theta readout implemented in HEP-FCC/FCCDetectors#56
Allows for instance to have two module-theta readouts with different grouping of cells (useful e.g. for debugging)

Tagging @gartrog , @BrieucF

@giovannimarchiori giovannimarchiori changed the title module-theta segmentation with merging per layer Implement module-theta readout (with per-layer merging) Aug 28, 2023
@kjvbrt
Copy link
Contributor

kjvbrt commented Sep 21, 2023

Hi @giovannimarchiori,
can the switch between different segmentation types be extracted into separate tool? Something like RedoSegmentationTool with interface defined in k4FWCore/k4Interface.

@giovannimarchiori
Copy link
Contributor Author

Hi @kjvbrt
I am not sure to understand your suggestion here.
BTW, of the 3 PRs (FCCDetectors, k4RecCalorimeter, k4SimGeant4) this is the least important one - it's useful IMO because it allows having multiple instances of the module-theta merged readout in a single job with different merging configurations so that makes debugging of the new segmentation much easier (I couldn't have done it without this feature), but apart from that, in real life one can run with a single segmentation with the baseline merging configuration. So I wouldn't spend much of my time to refactor this code for having merged - if you think it should leave only in my fork for my own debugging purposes, so be it.

@kjvbrt
Copy link
Contributor

kjvbrt commented Sep 21, 2023

Can you share your steering file, just to have an idea how you use the algorithm?

@giovannimarchiori
Copy link
Contributor Author

@kjvbrt
Copy link
Contributor

kjvbrt commented Sep 26, 2023

Hi @giovannimarchiori, thanks for the steering file.
OK, I see how it is used, let's merge it like this.

I wanted to avoid creating notion for segmentation type or in general some hierarchy among segmentations.

@kjvbrt kjvbrt merged commit 4a0576d into HEP-FCC:main Sep 26, 2023
@giovannimarchiori giovannimarchiori deleted the gmarchio-main-ModuleThetaReadoutNew branch April 18, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants