Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that input root files and output directories exist #96

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Check that input root files and output directories exist #96

merged 1 commit into from
Jul 15, 2024

Conversation

kjvbrt
Copy link
Contributor

@kjvbrt kjvbrt commented Jul 15, 2024 •
edited
Loading

Using ROOT's TSystem facilities...

@kjvbrt kjvbrt requested a review from giovannimarchiori July 15, 2024 12:40
@giovannimarchiori
Copy link
Contributor

Hi @kjvbrt,
thanks for these changes, they look good to me (and rather straightforward). It looks OK to me to go ahead and merge this PR, I would just suggest to modify a bit the description (not the title) of the PR to something more descriptive like "Check that input files and output directories exist"

giovannimarchiori
giovannimarchiori approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@giovannimarchiori giovannimarchiori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just see previous suggestion about PR description

@kjvbrt kjvbrt changed the title Guards when opening and saving to root files Check that input root files and output directories exist Jul 15, 2024
@kjvbrt kjvbrt merged commit 92e9e63 into HEP-FCC:main Jul 15, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giovannimarchiori giovannimarchiori giovannimarchiori approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kjvbrt @giovannimarchiori