update CellPositionsTool for HCal Allegro

[mmlynari]

• added new CellPositionsHCalPhiThetaSegTool to calculate radii of HCal barrel and HCal endcap on the flight from the geometry. Xml files that include extensions with radii of each layer and cells dimensions are HCalBarrel_TileCal_v02.xml and HCalEndcaps_ThreeParts_TileCal_v02.xml (now included in ALLEGRO_o1_v03.xml)

• this should be merged together with PR#350 in k4geo

[mmlynari]

Tagging @faltovaj , @giovannimarchiori and @BrieucF to have a look at the proposed changes

[giovannimarchiori]

Hi @mmlynari ,
thanks for this MR!
Have you tested that the code works as expected, and positions the cells properly in both the barrel and endcap calorimeters?
Also, the new version of the tool seems to be used both by barrel and endcap, so it might be good to rename it and remove "Barrel" from the name?
In the endcap, the radii are still dimensions along rho (is the endcap composed of nested disks) or do they correspond to some longitudinal granularity (I will also check the c++ that builds the detector to have a clearer picture)?

[mmlynari]

Hello @giovannimarchiori ,
yes, I have tested that the code correctly calculates radii of each layer in both barrel and endcap. I still need to have a closer look at the calculation of the z-coordinate in the endcap (at the first glance it seems to be off in a few cases), but this might point to a problem in the geometry itself. So I thought that we might have this first version of the cell positions tool with automated calculation of the radius and if more updates are needed (especially for the endcap), I will add them when I have better understanding of what is happening.
Right, I will remove 'Barrel' from the name. Should we still keep the original CellPositionsHCalBarrelPhiThetaSegTool and also have this new CellPositionsHCalPhiThetaSegTool?
In the endcap, the layer radii are in dimensions along rho. The geometry is very similar to the barrel, but in the endcap we have three cylinders along z, each with different inner radius and different layer number/dimensions.

[giovannimarchiori]

Hi @mmlynari,
now that the k4geo PR has been merged, we are close to merging also this PR, but you need to update the code (don't worry, the changes are minimal) following the migration from GaudiTool to AlgTool, as you can see here: https://github.com/HEP-FCC/k4RecCalorimeter/pull/101/files#diff-00d25010e6ca61c5b6c8a8f09cfc3af003cb599649fc729de7c2c30353693037

Basically replace everywhere GaudiTool with AlgTool in .h and .cpp, and
#include "GaudiAlg/GaudiTool.h"
with
#include "GaudiKernel/AlgTool.h"
in cpp

Then push to the branch used for the PR.
If things are OK, the tests for the nightlies should be succeeding and then we can merge

Thanks a lot!