Combined ECAL+HCAL topoclustering #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @BrieucF , could you assign a reviewer to this PR please (and then look at BrieucF/LAr_scripts#19)? |
|
I want to merge this when there will be new nightlies with Tong's changes. I tested it locally and it passes all tests. |
|
Great, thanks @kjvbrt !!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds code to create noise map and cell neighbour map for ECAL + HCAL barrel including links between ECAL outermost and HCAL innermost layers.
The code is developed mainly for the inclined cell readout of the Allegro ECAL but also work for an ECAL with more standard phi-theta readout, for which a corresponding cell positioning tool is also implemented in this PR.