Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dual readout Detectors added to FCCDetectors #34

Open
wants to merge 74 commits into
base: main
Choose a base branch
from

Conversation

atolosadelgado
Copy link

Hi,

This branch merged the dual readout Detectors sub-directory into the FCCDetectors repo.

I followed these steps:

  1. Filter the commits in the initial dual-readout repo using git filter, as explained here
  2. I pushed the filtered commits to an intermediate remote repo
  3. I merged the intermediate repo into FCCDetectors as explained here. Please, let me know if this is done in the proper way
  4. I included the new subdirectories in the CMakeLists as new commit

I checked that the proyect can be built using this flags,
cmake ../FCCDetectors/ -DCMAKE_INSTALL_PREFIX=$PWD/../install -DEXECUTABLE_OUTPUT_PATH=$PWD/../install

If the last flag EXECUTABLE_OUTPUT_PATH is not provided, there is an issue with the DD4hep macro called in line 31 of this file, and the project can not be configured.
line 31: dd4hep_configure_scripts( ddDRcalo DEFAULT_SETUP WITH_TESTS )

Can this be an issue?

Thanks you for your time.

SanghyunKo and others added 24 commits May 18, 2021 19:37
@vvolkl
Copy link
Member

vvolkl commented Dec 9, 2022

As discussed, please add a test and resolve the conflicts. The dd4hep_configure_scripts call can be removed.

@atolosadelgado
Copy link
Author

I added a test to scan the X0 parameter using the materialScan command from DD4hep. The bash script takes 3 arguments, the compact file and two arguments that are used for defining the test:
-axis: along the material scan is done. At the moment, 'x' or 'z'
-material check ('air', or 'noair'): if 'air' condition is passed as argument, the X0 is checked accordingly: the test will fail if X0 is larger than X0 of air. The opposite is true when 'noair' is passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants