Add support for complex types - basic implemented #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byrnHDF
added
Component - Object Library
byrnHDF
force-pushed
the
master-complex
branch
from
314075d to
d5ac702
Compare
byrnHDF
commented
Dec 18, 2024
| @@ -1738,8 +1795,8 @@ public static final Object allocateArray(final H5Datatype dtype, int numPoints) | |||
| for (int i = 0; i < numPoints; i++) | |||
| ((String[])data)[i] = ""; | |||
| } | |||
| else if (typeClass == HDF5Constants.H5T_INTEGER) { | |||
| log.trace("allocateArray(): class H5T_INTEGER"); | |||
| else if (typeClass == CLASS_INTEGER) { | |||
There was a problem hiding this comment.
Very critical that CLASS_* is not the same as HDF5Constants.H5T_*
| retVal |= isOpaque(); | ||
| retVal |= isBitField(); | ||
|
|
||
| return retVal; | ||
| } | ||
|
|
||
| private boolean datatypeClassIsComplex(long tclass) | ||
| private boolean datatypeClassIsComplicated(long tclass) |
There was a problem hiding this comment.
I had to do similar in HDF5 for the complex numbers - suggest that you use "composite" instead of complicated. Assuming here that these are for datatypes that are composed of other types, rather than actually "complicated" since that's ambiguous.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation.
Using tcomplex.h5, will display (read only) DatasetFloatComplex, AttributeFloatComplex and DatasetDoubleComplex.