Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the expected DDL output value #5128

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

hyoklee
Copy link
Member

@hyoklee hyoklee commented Nov 18, 2024

The test source code uses -99.0:

Particle1 fill_data[1] = {{"no data", -1, -1, -99.0F, -99.0}};

I386 Alpine CI test needs this patch to pass all tests.

This change may fail some other 64-bit systems.
If so, I suspect a bug in the HDF5 library.

@hyoklee hyoklee added the Component - Testing Code in test or testpar directories, GitHub workflows label Nov 18, 2024
Copy link
Contributor

@byrnHDF byrnHDF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the correct approach - why did this not fail until testing i386. First investigate the why of the failure.
And if i386 testing is correct and the 64-bit tests are correct - then add a special case.

@derobins derobins marked this pull request as draft December 2, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Testing Code in test or testpar directories, GitHub workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants