Skip to content

Commit

Permalink
remove HDF5 library version assert (#31)
Browse files Browse the repository at this point in the history
* This assertion fails the CI log-based-vol tests when run. It might also be better as a compile-time assertion. Remove the check and reintroduce it after finalizing semantic versioning in HDF5 and other needed updates to the lower and upper library versions when new HDF5 with semantic versioning is released.

* install missing Ubuntu packages for CI
  • Loading branch information
brtnfld authored Oct 15, 2024
1 parent 1efb602 commit 0cc42ca
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ jobs:
- name: Update repository code
run: |
sudo apt-get update
sudo apt-get install uuid-dev
- name: Install Dependencies (Linux--HDF5-release)
if: matrix.hdf5 == 'release'
Expand Down
6 changes: 5 additions & 1 deletion src/utils.c
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,11 @@ herr_t set_libver_bounds(configuration* pconfig, int rank, hid_t fapl)
H5F_libver_t low = H5F_LIBVER_EARLIEST, high = H5F_LIBVER_LATEST;
unsigned majnum, minnum, relnum;
assert((result = H5get_libversion(&majnum, &minnum, &relnum)) >= 0);
assert (majnum == 1 && minnum >= 8 && minnum <= 15);
/*
This might be better as a compile-time assert. Remove the check
and reintroduce it after finalizing semantic versioning in HDF5.
assert (majnum == 1 && minnum >= 8 && minnum <= 15);
*/

if (strncmp(pconfig->libver_bound_low, "earliest", 16) != 0)
{
Expand Down

0 comments on commit 0cc42ca

Please sign in to comment.