Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADIOS Backend: Python 3 support #190

Merged

Conversation

ax3l
Copy link
Contributor

@ax3l ax3l commented Feb 15, 2018

Adds Python 3 support to the ADIOS backend and enables it in testing again.

Related to #186

Enable the disabled ADIOS test in Travis-CI
@ax3l
Copy link
Contributor Author

ax3l commented Feb 15, 2018

ccing @jreadey @giumas ADIOS backend support enabled for Python 3

@giumas
Copy link
Collaborator

giumas commented Feb 15, 2018

@jreadey Can you add the py3 branch to Codacy?

firefox_2018-02-15_08-40-04

@@ -19,6 +19,7 @@
import sys
import os.path as op
import posixpath as pp
import six
Copy link
Collaborator

@giumas giumas Feb 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is to switch to Python 3 and avoid to increase the code complexity with all the ifs. Look at the other code in the py3 branch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you want Python 3+? Fine with me, sure

@ax3l
Copy link
Contributor Author

ax3l commented Feb 15, 2018

@giumas updated to Python 3+ only

Remove python 2 support in the ADIOS backend
@giumas
Copy link
Collaborator

giumas commented Feb 15, 2018

@ax3l Unless we introduce Py2/3 compatibility for all this branch, there is no advantage in just having the ADIOS plugin Py2/3 compatible!

@giumas giumas merged commit ca9dfd3 into HDFGroup:py3 Feb 15, 2018
@ax3l ax3l deleted the topic-reEnableADIOS branch February 15, 2018 16:29
@ax3l
Copy link
Contributor Author

ax3l commented Feb 15, 2018

Py3 only is ok with me, go ahead :)

@jreadey
Copy link
Member

jreadey commented Feb 15, 2018

I've added the py3 branch to Codacy.

@giumas
Copy link
Collaborator

giumas commented Feb 15, 2018

@jreadey Can you also add HDF Compass to the HDF Group's AppVeyor account?

@jreadey
Copy link
Member

jreadey commented Feb 16, 2018

Sure, here it is: https://ci.appveyor.com/project/jreadey/hdf-compass

@giumas
Copy link
Collaborator

giumas commented Feb 16, 2018

Does it also trigger the build for the py3 branch?

@jreadey
Copy link
Member

jreadey commented Feb 16, 2018

No.. I guess it stops with the first failed build.
I've updated to just build py3 for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants