-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADIOS Backend: Python 3 support #190
ADIOS Backend: Python 3 support #190
Conversation
Enable the disabled ADIOS test in Travis-CI
@jreadey Can you add the |
hdf_compass/adios_model/model.py
Outdated
@@ -19,6 +19,7 @@ | |||
import sys | |||
import os.path as op | |||
import posixpath as pp | |||
import six |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea is to switch to Python 3 and avoid to increase the code complexity with all the if
s. Look at the other code in the py3
branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So you want Python 3+? Fine with me, sure
@giumas updated to Python 3+ only |
Remove python 2 support in the ADIOS backend
b2137a8
to
0f74d7d
Compare
@ax3l Unless we introduce Py2/3 compatibility for all this branch, there is no advantage in just having the ADIOS plugin Py2/3 compatible! |
Py3 only is ok with me, go ahead :) |
I've added the py3 branch to Codacy. |
@jreadey Can you also add HDF Compass to the HDF Group's AppVeyor account? |
Sure, here it is: https://ci.appveyor.com/project/jreadey/hdf-compass |
Does it also trigger the build for the |
No.. I guess it stops with the first failed build. |
Adds Python 3 support to the ADIOS backend and enables it in testing again.
Related to #186