Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict numpy version for now #206

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Conversation

mattjala
Copy link
Contributor

Numpy just had its first major release in years, with breaking changes to its API. We should eventually add compatibility, but for now just restrict the numpy dependency to a pre-2.0.0 version.

@mattjala mattjala added the dependencies Pull requests that update a dependency file label Jun 18, 2024
@mattjala mattjala requested a review from jreadey June 18, 2024 17:14
@mattjala mattjala self-assigned this Jun 18, 2024
Copy link
Member

@jreadey jreadey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update requirements.txt as well.

Copy link
Member

@jreadey jreadey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jreadey jreadey merged commit 5e5b864 into HDFGroup:master Jun 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants