Multi-attribute API #202
Merged
Multi-attribute API #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be nice to support getting an arbitrary set of attributes by an list of names. |
|
Can you add getting attributes based on a glob pattern? Or would that be another PR? |
Glob patterns are already supported - see |
jreadey
reviewed
May 30, 2024
h5pyd/_hl/attrs.py
Outdated
| """ | ||
| if use_cache and (pattern or limit or marker): | ||
| raise ValueError("use_cache cannot be used with pattern, limit, or marker parameters") | ||
|
|
There was a problem hiding this comment.
What is the effect of use_cache? Doesn't seem like it's really being used for anything.
There was a problem hiding this comment.
It was initially used to stop the cache from being used with requests that have parameters which affect the result - this is now done in the HttpConn. It can be removed now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.